Improve core archive info #288
Conversation
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
phases/core_builder.go
Outdated
| if err == nil { | ||
| logger.Println(constants.LOG_LEVEL_INFO, constants.MSG_ARCHIVING_CORE_CACHE, targetArchivedCore) | ||
| } else { | ||
| logger.Println(constants.LOG_LEVEL_INFO, constants.MSG_CORE_CACHE_UNAVAILABLE, ctx.ActualPlatform.PlatformId) |
There was a problem hiding this comment.
This blames any error while copying the file on the core maintainers. I suppose the intended case is where the core does not use the proper .a filename, so the copy cannot find it? If so, then perhaps a separate check should be made to see if the .a filename exists and give this error if it does not? If the file does exist, but the copy fails, a new error message should probably be shown?
There was a problem hiding this comment.
I'd also add arduino.ar as a possible target but this clashes badly with specifications at http://goo.gl/QdCUjo .
I think that adding this check will make life terrible for maintainers of "incompatible" cores for a bit but will enormously speedup the adoption of proper naming (esp8266 just merged it in mainline esp8266/Arduino@85e6809#diff-d638a47d1ca0e2a5585fb34c7d7fb0f9L95 )
There was a problem hiding this comment.
Terrible in what way? Because users will start pestering them? Or because their incompatible cores will break or become slower (I can't see why or how)?
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
No description provided.